NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 4 | implement shell tools with python#453
Open
ZabihollahNamazi wants to merge 5 commits into
Open
Conversation
ZabihollahNamazi
added
📅 Sprint 4
ZabihollahNamazi
changed the title
LonMcGregor
reviewed
Jun 3, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on cat and ls. Your wc needs some changes though
| line_count = content.count("\n") | ||
| char_count = len(content) | ||
| if args.w: | ||
| print(f"word count of file {file} is : ", word_count) |
Contributor
There was a problem hiding this comment.
The formatting is not the same as the original wc program. Can you try to make it match?
Author
There was a problem hiding this comment.
thanks for the review , i have updated the code
LonMcGregor
added
Reviewed
ZabihollahNamazi
added
the
Needs Review
LonMcGregor
reviewed
Jun 8, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good changes, still a small change you could make to improve further
| if len(args.files) > 1: | ||
| total_parts = [] | ||
| if args.l: | ||
| total_parts.append(f"{total_lines:>7}") |
Contributor
There was a problem hiding this comment.
Good start. Some of this code is repeated quite a lot though, like all the printing, formatting. Can you find a way to generalise and reduce some of this duplication?
LonMcGregor
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
hi
could you please review my PR?
thanks